[SPARK-54488][BUILD] Fix Connect JVM client leaks protobuf-java-util in shading rules
#53191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
approved these changes
Nov 24, 2025
dongjoon-hyun
approved these changes
Nov 25, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pan3793 and @LuciferYang .
Merged to master/4.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 25, 2025
…` in shading rules ### What changes were proposed in this pull request? Fix Connect JVM client leaks `protobuf-java-util` in shading rules by setting `protobuf-java-util` to `compile` scope (was `provided`) ### Why are the changes needed? A bug fix, `spark-connect-client-jvm` jar should correctly shade all protobuf classes, same as the `spark-connect` server jar does. ### Does this PR introduce _any_ user-facing change? Yes, users who pull `spark-connect-client-jvm` as dependencies, will not see transitive `protobuf-java-util` dependency. ### How was this patch tested? ``` build/mvn clean install -DskipTests -pl sql/connect/client/jvm -am ``` ```patch [INFO] --- shade:3.6.0:shade (default) spark-connect-client-jvm_2.13 --- [INFO] Including org.apache.spark:spark-connect-common_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including io.grpc:grpc-netty:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-api:jar:1.76.0 in the shaded jar. [INFO] Including org.codehaus.mojo:animal-sniffer-annotations:jar:1.24 in the shaded jar. [INFO] Including io.grpc:grpc-core:jar:1.76.0 in the shaded jar. [INFO] Including com.google.android:annotations:jar:4.1.1.4 in the shaded jar. [INFO] Including io.grpc:grpc-context:jar:1.76.0 in the shaded jar. [INFO] Including io.perfmark:perfmark-api:jar:0.27.0 in the shaded jar. [INFO] Including io.grpc:grpc-util:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf:jar:1.76.0 in the shaded jar. [INFO] Including com.google.api.grpc:proto-google-common-protos:jar:2.59.2 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf-lite:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-services:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-stub:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-inprocess:jar:1.76.0 in the shaded jar. [INFO] Including io.netty:netty-codec-http2:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-common:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-buffer:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-resolver:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-base:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-http:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-compression:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler-proxy:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-socks:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport-native-unix-common:jar:4.2.7.Final in the shaded jar. [INFO] Including org.apache.spark:spark-sql-api_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including org.apache.arrow:arrow-vector:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-format:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-core:jar:18.3.0 in the shaded jar. [INFO] Including com.google.flatbuffers:flatbuffers-java:jar:25.2.10 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty-buffer-patch:jar:18.3.0 in the shaded jar. [INFO] Including com.google.protobuf:protobuf-java:jar:4.33.0 in the shaded jar. + [INFO] Including com.google.protobuf:protobuf-java-util:jar:4.33.0 in the shaded jar. [INFO] Including com.google.code.gson:gson:jar:2.11.0 in the shaded jar. [INFO] Including com.google.guava:guava:jar:33.4.8-jre in the shaded jar. [INFO] Including com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava in the shaded jar. [INFO] Including com.google.guava:failureaccess:jar:1.0.3 in the shaded jar. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53191 from pan3793/SPARK-54488. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 21b6166) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…` in shading rules ### What changes were proposed in this pull request? Fix Connect JVM client leaks `protobuf-java-util` in shading rules by setting `protobuf-java-util` to `compile` scope (was `provided`) ### Why are the changes needed? A bug fix, `spark-connect-client-jvm` jar should correctly shade all protobuf classes, same as the `spark-connect` server jar does. ### Does this PR introduce _any_ user-facing change? Yes, users who pull `spark-connect-client-jvm` as dependencies, will not see transitive `protobuf-java-util` dependency. ### How was this patch tested? ``` build/mvn clean install -DskipTests -pl sql/connect/client/jvm -am ``` ```patch [INFO] --- shade:3.6.0:shade (default) spark-connect-client-jvm_2.13 --- [INFO] Including org.apache.spark:spark-connect-common_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including io.grpc:grpc-netty:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-api:jar:1.76.0 in the shaded jar. [INFO] Including org.codehaus.mojo:animal-sniffer-annotations:jar:1.24 in the shaded jar. [INFO] Including io.grpc:grpc-core:jar:1.76.0 in the shaded jar. [INFO] Including com.google.android:annotations:jar:4.1.1.4 in the shaded jar. [INFO] Including io.grpc:grpc-context:jar:1.76.0 in the shaded jar. [INFO] Including io.perfmark:perfmark-api:jar:0.27.0 in the shaded jar. [INFO] Including io.grpc:grpc-util:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf:jar:1.76.0 in the shaded jar. [INFO] Including com.google.api.grpc:proto-google-common-protos:jar:2.59.2 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf-lite:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-services:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-stub:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-inprocess:jar:1.76.0 in the shaded jar. [INFO] Including io.netty:netty-codec-http2:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-common:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-buffer:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-resolver:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-base:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-http:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-compression:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler-proxy:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-socks:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport-native-unix-common:jar:4.2.7.Final in the shaded jar. [INFO] Including org.apache.spark:spark-sql-api_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including org.apache.arrow:arrow-vector:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-format:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-core:jar:18.3.0 in the shaded jar. [INFO] Including com.google.flatbuffers:flatbuffers-java:jar:25.2.10 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty-buffer-patch:jar:18.3.0 in the shaded jar. [INFO] Including com.google.protobuf:protobuf-java:jar:4.33.0 in the shaded jar. + [INFO] Including com.google.protobuf:protobuf-java-util:jar:4.33.0 in the shaded jar. [INFO] Including com.google.code.gson:gson:jar:2.11.0 in the shaded jar. [INFO] Including com.google.guava:guava:jar:33.4.8-jre in the shaded jar. [INFO] Including com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava in the shaded jar. [INFO] Including com.google.guava:failureaccess:jar:1.0.3 in the shaded jar. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53191 from pan3793/SPARK-54488. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix Connect JVM client leaks
protobuf-java-utilin shading rules by settingprotobuf-java-utiltocompilescope (wasprovided)Why are the changes needed?
A bug fix,
spark-connect-client-jvmjar should correctly shade all protobuf classes, same as thespark-connectserver jar does.Does this PR introduce any user-facing change?
Yes, users who pull
spark-connect-client-jvmas dependencies, will not see transitiveprotobuf-java-utildependency.How was this patch tested?
[INFO] --- shade:3.6.0:shade (default) @ spark-connect-client-jvm_2.13 --- [INFO] Including org.apache.spark:spark-connect-common_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including io.grpc:grpc-netty:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-api:jar:1.76.0 in the shaded jar. [INFO] Including org.codehaus.mojo:animal-sniffer-annotations:jar:1.24 in the shaded jar. [INFO] Including io.grpc:grpc-core:jar:1.76.0 in the shaded jar. [INFO] Including com.google.android:annotations:jar:4.1.1.4 in the shaded jar. [INFO] Including io.grpc:grpc-context:jar:1.76.0 in the shaded jar. [INFO] Including io.perfmark:perfmark-api:jar:0.27.0 in the shaded jar. [INFO] Including io.grpc:grpc-util:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf:jar:1.76.0 in the shaded jar. [INFO] Including com.google.api.grpc:proto-google-common-protos:jar:2.59.2 in the shaded jar. [INFO] Including io.grpc:grpc-protobuf-lite:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-services:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-stub:jar:1.76.0 in the shaded jar. [INFO] Including io.grpc:grpc-inprocess:jar:1.76.0 in the shaded jar. [INFO] Including io.netty:netty-codec-http2:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-common:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-buffer:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-resolver:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-base:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-http:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-compression:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-handler-proxy:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-codec-socks:jar:4.2.7.Final in the shaded jar. [INFO] Including io.netty:netty-transport-native-unix-common:jar:4.2.7.Final in the shaded jar. [INFO] Including org.apache.spark:spark-sql-api_2.13:jar:4.2.0-SNAPSHOT in the shaded jar. [INFO] Including org.apache.arrow:arrow-vector:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-format:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-core:jar:18.3.0 in the shaded jar. [INFO] Including com.google.flatbuffers:flatbuffers-java:jar:25.2.10 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty:jar:18.3.0 in the shaded jar. [INFO] Including org.apache.arrow:arrow-memory-netty-buffer-patch:jar:18.3.0 in the shaded jar. [INFO] Including com.google.protobuf:protobuf-java:jar:4.33.0 in the shaded jar. + [INFO] Including com.google.protobuf:protobuf-java-util:jar:4.33.0 in the shaded jar. [INFO] Including com.google.code.gson:gson:jar:2.11.0 in the shaded jar. [INFO] Including com.google.guava:guava:jar:33.4.8-jre in the shaded jar. [INFO] Including com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava in the shaded jar. [INFO] Including com.google.guava:failureaccess:jar:1.0.3 in the shaded jar.Was this patch authored or co-authored using generative AI tooling?
No.