[SPARK-54491][SQL] Fix insert into temp view on DSv2 table failure #53196
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you double-check Maven build failure, @manuzhang ?
Error: ] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:1194: not found: type V2TableReference
Error: ] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:1195: value resolveReference is not a member of org.apache.spark.sql.catalyst.analysis.RelationResolution
Member
|
cc @gengliangwang , too. |
manuzhang
force-pushed
the
FIX-SPARK-54491
branch
from
e76cb87 to
2929ee1
Compare
dongjoon-hyun
changed the title
aokolnychyi
reviewed
Nov 25, 2025
| val relation = table match { | ||
| case u: UnresolvedRelation if !u.isStreaming => | ||
| resolveRelation(u).getOrElse(u) | ||
| case r: V2TableReference => |
Contributor
There was a problem hiding this comment.
Can this ever be DataSourceV2Relation itself? I am asking primarily as there is resolveAsV2Relation that handles both below.
Member
Author
There was a problem hiding this comment.
We already have ResolveInsertInto to handle it.
aokolnychyi
approved these changes
Nov 25, 2025
dongjoon-hyun
approved these changes
Nov 25, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @manuzhang and @aokolnychyi .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Resolve `V2TableReference` for table in `InsertIntoStatement`. ### Why are the changes needed? #52876 brought in `V2TableReference` which broke relation resolution for insert into temp view on DSv2 table. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53196 from manuzhang/FIX-SPARK-54491. Authored-by: manuzhang <owenzhang1990@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3f5a2b9) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Contributor
|
good catch! late LGTM |
Contributor
|
Thanks, @manuzhang! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Resolve `V2TableReference` for table in `InsertIntoStatement`. ### Why are the changes needed? apache#52876 brought in `V2TableReference` which broke relation resolution for insert into temp view on DSv2 table. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53196 from manuzhang/FIX-SPARK-54491. Authored-by: manuzhang <owenzhang1990@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolve
V2TableReferencefor table inInsertIntoStatement.Why are the changes needed?
#52876 brought in
V2TableReferencewhich broke relation resolution for insert into temp view on DSv2 table.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UT.
Was this patch authored or co-authored using generative AI tooling?
No.