[WIP][SPARK-54505][UI][SHUFFLE] Correct the arguments order of createMetrics call in makeNegative #53218
+172
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwen624
force-pushed
the
makeNegative-arg-order
branch
2 times, most recently
from
44ec6e2 to
36067cd
Compare
jiwen624
force-pushed
the
makeNegative-arg-order
branch
from
36067cd to
7a23a9b
Compare
jiwen624
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the method
org.apache.spark.status.LiveEntityHelpers.makeNegative, it callscreateMetricswith a wrong arguments order which passes values to wrong positions. The order is wrong starting from theshufflePushReadMetrics. corruptMergedBlockChunksWhy are the changes needed?
Passing argument values to wrong positions messes up the method call and negates metrics with wrong values.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case.
Was this patch authored or co-authored using generative AI tooling?
No