[SPARK-54521][SQL] Add to and from WKB for Geometry type #53227
+2,841
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
Nov 26, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Is this for Apache Spark 4.2.0 only, right?
To be clear, let me hold this PR a little, @szehon-ho .
Member
Author
|
yes it is for 4.2, geo type seems disabled in 4.1 |
szehon-ho
commented
Nov 27, 2025
| files="src/main/java/org/apache/spark/examples/JavaLogQuery.java"/> | ||
| <suppress checks="LineLength" | ||
| files="src/main/java/org/apache/hive/service/*"/> | ||
| <suppress checks="LineLength" |
Member
Author
There was a problem hiding this comment.
easier to see WKB hex strings in one line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Geometry toWKB and fromWKB methods. These will serialize and deserialize Geometry objects to and from WKB (Well Known Binary) standard.
We implement our own reader/writer to avoid compile time dependency on JTS from Spark
Why are the changes needed?
Read geometry stored as WKB in external data sources like Iceberg, and also for users who are interested in utils to convert from and to WKB.
Does this PR introduce any user-facing change?
No, feature is not enabled yet.
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
Yes claude 4.5 sonnet