[SPARK-10395] [SQL] Simplifies CatalystReadSupport #8553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #41870 has finished for PR 8553 at commit
|
There was a problem hiding this comment.
Moved this method in front of prepareForRead() for better readability, since this method is called right before prepareForRead().
liancheng
force-pushed
the
spark-10395/simplify-parquet-read-support
branch
from
d7173a9 to
d8a1ba4
Compare
|
Test build #42412 has finished for PR 8553 at commit
|
|
Test build #42543 has finished for PR 8553 at commit
|
There was a problem hiding this comment.
Why did we pass in the maybeRowSchema before? Seems it was not used by prepareForRead.
There was a problem hiding this comment.
IIRC it was used by the old Parquet support code, which has already been removed.
|
LGTM |
|
Merged into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to SPARK-10395 for details.