Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Oct 2, 2015

Recommend --master yarn --deploy-mode {cluster,client} consistently in docs.
Follow-on to #8385
CC @nssalian

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still using yarn-client here.

@SparkQA
Copy link

SparkQA commented Oct 2, 2015

Test build #43196 has finished for PR 8968 at commit 47d9e8a.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 3, 2015

Test build #43199 has finished for PR 8968 at commit e8db144.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 82bbc2a Oct 4, 2015
@srowen srowen deleted the SPARK-9570 branch October 4, 2015 08:40
@tgravescs
Copy link
Contributor

@srowen , what happened here, why was this closed, it looks like it was committed but I don't see anyone +1. I was mostly good with it but it would have been nice to look at the final version.

@srowen
Copy link
Member Author

srowen commented Oct 5, 2015

Ah, I thought you had reviewed this and the previous iteration of this PR also? seemed pretty cut and dried to me at this stage. I don't know how long to wait for your explicit ack. In this case, being just docs, the downside of committing early is small -- you can always follow on with another commit if you really had something to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants