Skip to content

Conversation

davies
Copy link
Contributor

@davies davies commented Oct 19, 2015

This PR introduce a new feature to run SQL directly on files without create a table, for example:

select id from json.`path/to/json/files` as j

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #43953 has finished for PR 9173 at commit d1b0463.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 20, 2015

The syntax looks good to me. Couple comments:

  1. Let's add a config variable so users can disable this.
  2. Make sure the error messages make sense. e.g. if there is a database named "json", the error message should say "there is no table or file named xxx"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table not found

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #44007 has finished for PR 9173 at commit 4e7a995.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #44008 has finished for PR 9173 at commit 827bdab.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 21, 2015

Test build #44010 has finished for PR 9173 at commit 683921f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

Thanks! Merging to master.

@asfgit asfgit closed this in f8c6bec Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants