Skip to content

Conversation

nongli
Copy link
Contributor

@nongli nongli commented Nov 3, 2015

No description provided.

@srowen
Copy link
Member

srowen commented Nov 3, 2015

Dumb question, but why wasn't this part of SPARK-11329? or attached to it?

@nongli nongli changed the title [SPARK-11483] [SQL] Cleanup from spark-11329 fix. [SPARK-11329] [SQL] Cleanup from spark-11329 fix. Nov 3, 2015
@nongli
Copy link
Contributor Author

nongli commented Nov 3, 2015

My bad. Does this do the trick?

@yhuai
Copy link
Contributor

yhuai commented Nov 3, 2015

@srowen Since the original pr did not have any fundamental issue and we will probably see a burst of commits (as we will cut the branch soon), I committed the original one to avoid potential merge conflict. We will attach this pr to the original jira. So, it will be clear from the commit history.

@srowen
Copy link
Member

srowen commented Nov 3, 2015

I figured. My motivation is mostly to make sure that it's easy to find all the commits that belong to one logical change. And maybe reducing noise but that's minor.

@yhuai
Copy link
Contributor

yhuai commented Nov 3, 2015

@srowen yeah. That's a good point.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44945 has finished for PR 9442 at commit a53bad4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class ExecutorLostFailure(\n * case class DecimalLit(chars: String) extends Token\n

@yhuai
Copy link
Contributor

yhuai commented Nov 4, 2015

Thanks! LGTM. Merging to master!

@asfgit asfgit closed this in e352de0 Nov 4, 2015
@nongli nongli deleted the spark-11483 branch November 19, 2015 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants