-
Couldn't load subscription status.
- Fork 28.9k
[SPARK-11829] [ML] Add read/write to estimators under ml.feature (II) #9838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #46323 has finished for PR 9838 at commit
|
|
Jenkins, test this please. |
|
Test build #46326 has finished for PR 9838 at commit
|
|
Test build #46327 has finished for PR 9838 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as StandardScalerModel, we can not construct PCAModel directly by specifying the variable k, so test estimator and model in one case with testEstimatorAndModelReadWrite.
|
Test build #46332 has finished for PR 9838 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we keep them private[spark] for this release? We should not introduce unplanned APIs at this stage.
|
LGTM except two minor issues commented inline. |
|
Test build #46384 has finished for PR 9838 at commit
|
Add read/write support to the following estimators under spark.ml: * ChiSqSelector * PCA * VectorIndexer * Word2Vec Author: Yanbo Liang <ybliang8@gmail.com> Closes #9838 from yanboliang/spark-11829. (cherry picked from commit 3b7f056) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Merged into master and branch-1.6. Thanks! |
Add read/write support to the following estimators under spark.ml: