STORM-964, add config for worker logwriter to restrict its mem usage #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would it be possible to expand 'lw' to 'logwriter'? |
Author
|
Good suggestion! Updated. |
Contributor
There was a problem hiding this comment.
should use storm-conf but not conf here?
topo-worker-logwriter-childopts (storm-conf TOPOLOGY-WORKER-LOGWRITER-CHILDOPTS)
Author
There was a problem hiding this comment.
Good catch. Since user may have configuration for this in topology's stormconf.ser. Updated.
Contributor
|
The change looks good to me +1, but I want to give @knusbaum some time to follow up on his review too. |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log writer process that writes out stderr and stdout should have a config that controls it's memory usage and it should default to a very small value, probably 50MB in most cases.
To address above issue, one new parameter is defined for logwriter's jvmopts: "topology.worker.lw.childopts".
The default heap size of logwriter is set as 64M, or user can override it through "-c topology.worker.lw.childopts='xxxx " when submitting a topology.