[STORM-1005]replace default storm.local.dir value to absolute path. #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
One thing we should keep in mind is, some users are using Storm in Windows environment. |
Contributor
Author
|
If make storm.local.dir to a relative path is better,how about make the path relative to where storm is installed rather than where user start the storm processes. |
Contributor
|
Sounds good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my supervisors shutdown by it self after running for a few weeks.After I restart the supervisor from another directory(actually I don't remember which directory I started the supervisor at first.Then the workers running on that machine become wild.They running as usual,but the supervisor can't detect them,and I can't shutdown them with
storm kill.When I submit a new topology,the supervisor will try to start new a worker with the port running workers already used,it will cause failure.It's hard form a typical user to know why such exception happens,so I think it's better to set storm.local.dir as a absolute path.
If
storm.local.dircan be set to$STORM_HOME/storm-local,it may be best.But it seems yaml file only support constant values.