advance kafka offset when deserializer yields no object

[prokopowicz]

also removes some tab-indenting in the surrounding code.

When a custom scheme returns an empty list of object-lists to the partition manager, it should be handled the same as null. Otherwise, the partition reader will be stuck at that offset.

[revans2]

This doesn't even compile.

[ERROR] /home/travis/build/apache/storm/external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java:[139,39] cannot find symbol

symbol: variable iterator

location: variable tups of type java.lang.Iterable<java.util.List<java.lang.Object>>

I think it needs to be tups.iterator().hasNext()

[prokopowicz]

sorry :( I am pushing another commit now

[revans2]

@prokopowicz I am +1 for merging this in. Is there a JIRA associated with this change?

[HeartSaVioR]

+1, too.
@prokopowicz
Since this is a bug, I'd like to record this to JIRA issue before merging. Could you file a JIRA, please?

[Crim]

+1 running into this issue as well

[prokopowicz]

I issued this JIRA regarding the bug:

https://issues.apache.org/jira/browse/STORM-1094

On Tue, Oct 6, 2015 at 3:40 PM, Jungtaek Lim notifications@github.com
wrote:

+1, too.
@prokopowicz https://github.com/prokopowicz
Since this is a bug, I'd like to record this to JIRA issue before merging.
Could you file a JIRA, please?

—
Reply to this email directly or view it on GitHub
#758 (comment).

[HeartSaVioR]

Great, I'll merge it.