Renames for consistency with other methods.

Author: semohr

superset/utils/core.py

@@ -1768,24 +1768,26 @@ def extract_display_labels(
         return []
 
     # Build column -> label mapping (skip self-references)
-    col_to_label = {}
+    columns_to_label = {}
     if label_map:
         for label, cols in label_map.items():
             for col in cols:
-                if label != col and col not in col_to_label:
-                    col_to_label[col] = label
+                if label != col and col not in columns_to_label:
+                    columns_to_label[col] = label
 
     # Build column -> object mapping
-    col_to_obj = {}
+    columns_by_name: dict[str, Any] = {}
     if datasource:
-        for col in datasource.columns:
-            name = col.get("column_name") if isinstance(col, dict) else col.column_name
-            if name:
-                col_to_obj[name] = col
+        for column in datasource.columns:
+            if isinstance(column, dict):
+                if column_name := column.get("column_name"):
+                    columns_by_name[column_name] = column
+            else:
+                columns_by_name[column.column_name] = column
 
     return [
-        col_to_label.get(col)
-        or (get_column_name(col_to_obj[col]) if col in col_to_obj else col)
+        columns_to_label.get(col)
+        or (get_column_name(columns_by_name[col]) if col in columns_by_name else col)
         for col in colnames
     ]