feat(plugin-chart-country-map): wire up the "Show flying islands" toggle end-to-end

The control was removed earlier because it was a documented no-op —
the build pipeline repositioned features per flying_islands.yaml but
didn't tag them, so the runtime drop logic had nothing to filter on.
Now actually functional:

- build.py: apply_flying_islands sets `_flying: true` on every feature
  it repositions (FRA's 5 DROMs, USA's Hawaii/Alaska/Puerto Rico, ESP
  Canary Islands, NOR Svalbard, PRT Madeira/Azores, etc.)
- controlPanel.tsx: re-add the `show_flying_islands` checkbox (default
  on, renderTrigger so the projection refits without re-querying)
- CountryMap.tsx: filterFeatures drops _flying-tagged features when the
  toggle is off; fit-to-selection projection automatically zooms to
  the remaining mainland
- types: declare optional `_flying` property
- Tests: assert control presence + default value; remove the
  intentionally-absent assertion
- Regenerated 5 admin1 files + the france_overseas composite to embed
  the new tags (only countries with flying_islands rules differ)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: Superset Dev

superset-frontend/plugins/plugin-chart-country-map/scripts/build.py

@@ -793,6 +793,10 @@ def apply_flying_islands(
                 f["geometry"] = _translate_and_scale(
                     f["geometry"], offset=offset, scale=scale
                 )
+                # Tag the feature so the frontend can drop it at runtime
+                # via the "Show flying islands" toggle. Without this tag
+                # the toggle would have nothing to filter on.
+                props["_flying"] = True
                 n_repos += 1
 
         # Drop outside bbox — only meaningful at Admin 1 (where each

superset-frontend/plugins/plugin-chart-country-map/src/CountryMap.tsx

@@ -40,6 +40,9 @@ interface FeatureProps {
   iso_3166_2?: string;
   adm0_a3?: string;
   name?: string;
+  /** Set by the build pipeline on features moved by flying_islands.yaml's
+   * repositions — drives the "Show flying islands" runtime toggle. */
+  _flying?: boolean;
   [k: string]: unknown;
 }
 
@@ -74,27 +77,31 @@ function featureName(feature: Feature, language: string): string {
   return (p[langKey] as string) || p.name || '';
 }
 
+/**
 /**
  * Filter a feature collection by include/exclude lists + the
  * flying-islands toggle.
  *
  * - includes: if non-empty, keep ONLY features whose key is in this list
  * - excludes: drop features whose key is in this list
- * - showFlyingIslands: when false, drop features tagged as "flying" (the
- *   build pipeline doesn't currently tag these in feature properties; for
- *   the POC we treat the flag as a no-op until tagging is added)
+ * - showFlyingIslands: when false, drop features the build pipeline
+ *   tagged as repositioned (`_flying: true`) — e.g. France's DROMs
+ *   moved into insets near the mainland. Projection auto-refits to
+ *   the remaining features.
  */
 function filterFeatures(
   features: Feature[],
   includes: string[],
   excludes: string[],
+  showFlyingIslands: boolean,
 ): Feature[] {
   const incSet = new Set(includes);
   const excSet = new Set(excludes);
   return features.filter(f => {
     const k = featureKey(f);
     if (incSet.size > 0 && !incSet.has(k)) return false;
     if (excSet.has(k)) return false;
+    if (!showFlyingIslands && f.properties?._flying === true) return false;
     return true;
   });
 }
@@ -180,8 +187,14 @@ const CountryMap: FC<CountryMapTransformedProps> = props => {
       geo.features as Feature[],
       formData.region_includes ?? [],
       formData.region_excludes ?? [],
+      formData.show_flying_islands !== false,
     );
-  }, [geo, formData.region_includes, formData.region_excludes]);
+  }, [
+    geo,
+    formData.region_includes,
+    formData.region_excludes,
+    formData.show_flying_islands,
+  ]);
 
   // ---- Color scale -----------------------------------------------------
   const colorByKey = useMemo<Record<string, string>>(() => {

superset-frontend/plugins/plugin-chart-country-map/src/data/manifest.json

@@ -36,7 +36,10 @@
     "usa",
     "vnm"
   ],
-  "admin_levels": [0, 1],
+  "admin_levels": [
+    0,
+    1
+  ],
   "countries_by_worldview": {
     "arg": [],
     "bdg": [],
@@ -317,7 +320,7 @@
     {
       "id": "france_overseas",
       "worldview": "ukr",
-      "size_bytes": 322058,
+      "size_bytes": 322133,
       "country": "FRA"
     }
   ]

superset-frontend/plugins/plugin-chart-country-map/src/plugin/controlPanel.tsx

@@ -484,13 +484,24 @@ const config: ControlPanelConfig = {
             },
           },
         ],
-        // `show_flying_islands` is intentionally absent from this control
-        // set: the build pipeline already repositions known flying-islands
-        // groups (Hawaii, Alaska, French overseas territories, ...) at
-        // build time per `flying_islands.yaml`, and the runtime drop
-        // toggle requires per-feature `_flying: true` tags which the
-        // build doesn't currently emit. Bringing the control back is a
-        // single-line follow-up once that tagging lands — see the SIP.
+        [
+          {
+            name: 'show_flying_islands',
+            config: {
+              type: 'CheckboxControl',
+              label: t('Show flying islands'),
+              description: t(
+                'When on (default), territories that the build pipeline ' +
+                  'repositioned into insets near the mainland (e.g. ' +
+                  'Hawaii/Alaska for US, French DROMs for France) are ' +
+                  'visible. Turn off to drop those features entirely; the ' +
+                  'projection auto-refits to the remaining mainland.',
+              ),
+              default: true,
+              renderTrigger: true,
+            },
+          },
+        ],
         [
           {
             name: 'name_language',

superset-frontend/plugins/plugin-chart-country-map/test/plugin/controlPanel.test.ts

@@ -56,9 +56,6 @@ const findControl = (name: string) => {
 
 test('all required new controls are present', () => {
   const names = allControlNames();
-  // The full set of controls the redesign introduced. `show_flying_islands`
-  // is intentionally absent — it's a no-op until the build pipeline tags
-  // features as flying, and showing a dead toggle was misleading.
   for (const required of [
     'worldview',
     'admin_level',
@@ -67,15 +64,17 @@ test('all required new controls are present', () => {
     'composite',
     'region_includes',
     'region_excludes',
+    'show_flying_islands',
     'name_language',
   ]) {
     expect(names).toContain(required);
   }
 });
 
-test('show_flying_islands is intentionally absent (no-op until features are tagged)', () => {
-  const names = allControlNames();
-  expect(names).not.toContain('show_flying_islands');
+test('show_flying_islands defaults to true', () => {
+  const c = findControl('show_flying_islands');
+  expect(c).not.toBeNull();
+  expect(c.default).toBe(true);
 });
 
 test('worldview defaults to ukr (Superset editorial choice)', () => {