Skip to content

Commit 78fada7

Browse files
authored
Merge branch 'master' into fix-no-top-level-tab
2 parents b71c556 + 5b5dd01 commit 78fada7

42 files changed

Lines changed: 3701 additions & 653 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

pyproject.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ dependencies = [
114114

115115
[project.optional-dependencies]
116116

117-
athena = ["pyathena[pandas]>=2, <3"]
117+
athena = ["pyathena[pandas]>=2, <4"]
118118
aurora-data-api = ["preset-sqlalchemy-aurora-data-api>=0.2.8,<0.3"]
119119
bigquery = [
120120
"pandas-gbq>=0.19.1",
@@ -135,7 +135,7 @@ databricks = [
135135
"databricks-sqlalchemy==1.0.5",
136136
]
137137
db2 = ["ibm-db-sa>0.3.8, <=0.4.0"]
138-
denodo = ["denodo-sqlalchemy~=1.0.6"]
138+
denodo = ["denodo-sqlalchemy>=1.0.6,<2.1.0"]
139139
dremio = ["sqlalchemy-dremio>=1.2.1, <4"]
140140
drill = ["sqlalchemy-drill>=1.1.4, <2"]
141141
druid = ["pydruid>=0.6.5,<0.7"]
@@ -158,7 +158,7 @@ hive = [
158158
"thrift>=0.14.1, <1.0.0",
159159
"thrift_sasl>=0.4.3, < 1.0.0",
160160
]
161-
impala = ["impyla>0.16.2, <0.17"]
161+
impala = ["impyla>0.16.2, <0.23"]
162162
kusto = ["sqlalchemy-kusto>=3.0.0, <4"]
163163
kylin = ["kylinpy>=2.8.1, <2.9"]
164164
mssql = ["pymssql>=2.2.8, <3"]
@@ -171,7 +171,7 @@ ocient = [
171171
"shapely",
172172
"geojson",
173173
]
174-
oracle = ["cx-Oracle>8.0.0, <8.1"]
174+
oracle = ["cx-Oracle>8.0.0, <8.4"]
175175
parseable = ["sqlalchemy-parseable>=0.1.3,<0.2.0"]
176176
pinot = ["pinotdb>=5.0.0, <6.0.0"]
177177
playwright = ["playwright>=1.37.0, <2"]
@@ -197,7 +197,7 @@ tdengine = [
197197
]
198198
teradata = ["teradatasql>=16.20.0.23"]
199199
thumbnails = [] # deprecated, will be removed in 7.0
200-
vertica = ["sqlalchemy-vertica-python>=0.5.9, < 0.6"]
200+
vertica = ["sqlalchemy-vertica-python>= 0.5.9, < 0.7"]
201201
netezza = ["nzalchemy>=11.0.2"]
202202
starrocks = ["starrocks>=1.0.0"]
203203
doris = ["pydoris>=1.0.0, <2.0.0"]

superset-frontend/package-lock.json

Lines changed: 24 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

superset-frontend/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@
196196
"memoize-one": "^5.2.1",
197197
"mousetrap": "^1.6.5",
198198
"mustache": "^4.2.0",
199-
"nanoid": "^5.1.9",
199+
"nanoid": "^5.1.11",
200200
"ol": "^10.9.0",
201201
"pretty-ms": "^9.3.0",
202202
"query-string": "9.3.1",
@@ -330,7 +330,7 @@
330330
"eslint-plugin-no-only-tests": "^3.4.0",
331331
"eslint-plugin-prettier": "^5.5.5",
332332
"eslint-plugin-react-prefer-function-component": "^5.0.0",
333-
"eslint-plugin-react-you-might-not-need-an-effect": "^0.9.3",
333+
"eslint-plugin-react-you-might-not-need-an-effect": "^0.10.0",
334334
"eslint-plugin-storybook": "^0.8.0",
335335
"eslint-plugin-testing-library": "^7.16.2",
336336
"eslint-plugin-theme-colors": "file:eslint-rules/eslint-plugin-theme-colors",
@@ -345,7 +345,7 @@
345345
"jest-html-reporter": "^4.4.0",
346346
"jest-websocket-mock": "^2.5.0",
347347
"js-yaml-loader": "^1.2.2",
348-
"jsdom": "^29.1.0",
348+
"jsdom": "^29.1.1",
349349
"lerna": "^9.0.4",
350350
"lightningcss": "^1.32.0",
351351
"mini-css-extract-plugin": "^2.10.2",

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@
1818
*/
1919

2020
import { isMatrixifyVisible } from './matrixifyControls';
21+
import type { ControlStateMapping } from '../types';
2122

2223
/**
2324
* Helper to build a controls object matching the shape used by
2425
* control panel visibility callbacks.
2526
*/
2627
function makeControls(
2728
overrides: Record<string, unknown> = {},
28-
): Record<string, { value: unknown }> {
29+
): ControlStateMapping {
2930
const defaults: Record<string, unknown> = {
3031
matrixify_enable: false,
3132
matrixify_mode_rows: 'disabled',
@@ -36,7 +37,7 @@ function makeControls(
3637
const merged = { ...defaults, ...overrides };
3738
return Object.fromEntries(
3839
Object.entries(merged).map(([k, v]) => [k, { value: v }]),
39-
);
40+
) as ControlStateMapping;
4041
}
4142

4243
// ── matrixify_enable guard ──────────────────────────────────────────

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import { t } from '@apache-superset/core/translation';
2222
import { validateNonEmpty } from '@superset-ui/core';
23-
import { SharedControlConfig } from '../types';
23+
import { ControlStateMapping, SharedControlConfig } from '../types';
2424
import { dndAdhocMetricControl } from './dndControls';
2525
import { defineSavedMetrics } from '../utils';
2626

@@ -29,9 +29,12 @@ import { defineSavedMetrics } from '../utils';
2929
* Controls for transforming charts into matrix/grid layouts
3030
*/
3131

32-
// Utility function to check if matrixify controls should be visible
32+
// Utility function to check if matrixify controls should be visible.
33+
// Controls both visibility callbacks and validator injection via mapStateToProps.
34+
// The matrixify_enable guard prevents hidden validators from firing on
35+
// pre-revamp charts with stale matrixify_mode defaults (fix for #38519).
3336
const isMatrixifyVisible = (
34-
controls: any,
37+
controls: ControlStateMapping | undefined,
3538
axis: 'rows' | 'columns',
3639
mode?: 'metrics' | 'dimensions',
3740
selectionMode?: 'members' | 'topn' | 'all',

0 commit comments

Comments
 (0)