Commit d9f04d6
fix(plugin-chart-country-map): admin_level string/number coercion + lower row_limit default
Two user-visible bugs fixed:
1. **"No GeoJSON URL resolved" with admin_level + country set.** The
SelectControl serializes admin_level as a string ('0' / '1' /
'aggregated'), but transformProps was comparing against numbers
(`adminLevel === 1`), so real-world charts silently fell through
every branch and returned a null URL. Existing tests passed because
they used number values directly. Normalize to string at the top
of transformProps and compare against string constants; add two
regression tests that pass the string form-data values reality
actually sends.
2. **Default row_limit of 50000 exceeds many deployments' configured
ROW_LIMIT ceiling, blocking Update Chart.** Choropleths key one row
per region — even the densest country maps (France 101 departments,
India 36 states, US 51 territories) are well under 10k rows.
Override the shared default to 10000 via controlOverrides.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent ba4367d commit d9f04d6
3 files changed
Lines changed: 43 additions & 3 deletions
File tree
- superset-frontend/plugins/plugin-chart-country-map
- src/plugin
- test/plugin
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
577 | 585 | | |
578 | 586 | | |
579 | 587 | | |
| |||
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
57 | 62 | | |
58 | 63 | | |
59 | 64 | | |
60 | 65 | | |
61 | 66 | | |
62 | 67 | | |
63 | | - | |
| 68 | + | |
64 | 69 | | |
65 | | - | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
| |||
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
66 | 93 | | |
67 | 94 | | |
68 | 95 | | |
| |||
0 commit comments