Skip to content

SYNAPSE-1134 Fixed calls of getClass() on instances of Class #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SYNAPSE-1134 Fixed calls of getClass() on instances of Class #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/core/src/main/java/org/apache/synapse/config/xml/POJOCommandMediatorSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public OMElement serializeSpecificMediator(Mediator m) {
OMElement pojoCommand = fac.createOMElement("pojoCommand", synNS);
saveTracingState(pojoCommand, mediator);

if (mediator.getCommand() != null && mediator.getCommand().getClass().getName() != null) {
if (mediator.getCommand() != null && mediator.getCommand().getName() != null) {
pojoCommand.addAttribute(fac.createOMAttribute(
"name", nullNS, mediator.getCommand().getName()));
} else {
Expand Down
14 changes: 7 additions & 7 deletions modules/core/src/main/java/org/apache/synapse/mediators/ext/AnnotatedCommandMediator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public boolean mediate(MessageContext synCtx) {
}

if (synLog.isTraceOrDebugEnabled()) {
synLog.traceOrDebug("Creating a new instance of POJO class : " + getCommand().getClass());
synLog.traceOrDebug("Creating a new instance of POJO class : " + getCommand());
}

Object commandObject = null;
Expand All @@ -67,7 +67,7 @@ public boolean mediate(MessageContext synCtx) {
commandObject = getCommand().newInstance();
} catch (Exception e) {
handleException("Error creating an instance of the POJO command class : " +
getCommand().getClass(), e, synCtx);
getCommand(), e, synCtx);
}

synLog.traceOrDebug("Instance created, setting static and dynamic properties");
Expand All @@ -86,7 +86,7 @@ public boolean mediate(MessageContext synCtx) {
if (f.getType().equals(String.class)) {
v = xpath.stringValueOf(synCtx);
} else {
throw new UnsupportedOperationException("non-String types not supportted yet");
throw new UnsupportedOperationException("non-String types not supported yet");
}
try {
f.set(commandObject, v);
Expand All @@ -101,7 +101,7 @@ public boolean mediate(MessageContext synCtx) {
if (m.getParameterTypes().length == 1 && m.getParameterTypes()[0].equals(String.class)) {
v = xpath.stringValueOf(synCtx);
} else {
throw new UnsupportedOperationException("non-String types not supportted yet");
throw new UnsupportedOperationException("non-String types not supported yet");
}
try {
m.invoke(commandObject, v);
Expand All @@ -118,7 +118,7 @@ public boolean mediate(MessageContext synCtx) {
((Command) commandObject).execute();
} catch (Exception e) {
handleException("Error invoking POJO command class : "
+ getCommand().getClass(), e, synCtx);
+ getCommand(), e, synCtx);
}

} else {
Expand All @@ -129,10 +129,10 @@ public boolean mediate(MessageContext synCtx) {
exeMethod.invoke(commandObject, new Object[]{});
} catch (NoSuchMethodException e) {
handleException("Cannot locate an execute() method on POJO class : " +
getCommand().getClass(), e, synCtx);
getCommand(), e, synCtx);
} catch (Exception e) {
handleException("Error invoking the execute() method on POJO class : " +
getCommand().getClass(), e, synCtx);
getCommand(), e, synCtx);
}
}

Expand Down
10 changes: 5 additions & 5 deletions modules/core/src/main/java/org/apache/synapse/mediators/ext/POJOCommandMediator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public boolean mediate(MessageContext synCtx) {
}

if (synLog.isTraceOrDebugEnabled()) {
synLog.traceOrDebug("Creating a new instance of POJO class : " + command.getClass());
synLog.traceOrDebug("Creating a new instance of POJO class : " + command);
}

Object commandObject = null;
Expand All @@ -112,7 +112,7 @@ public boolean mediate(MessageContext synCtx) {
commandObject = command.newInstance();
} catch (Exception e) {
handleException("Error creating an instance of the POJO command class : " +
command.getClass(), e, synCtx);
command, e, synCtx);
}

synLog.traceOrDebug("Instance created, setting static and dynamic properties");
Expand Down Expand Up @@ -143,7 +143,7 @@ public boolean mediate(MessageContext synCtx) {
((Command) commandObject).execute();
} catch (Exception e) {
handleException("Error invoking POJO command class : "
+ command.getClass(), e, synCtx);
+ command, e, synCtx);
}

} else {
Expand All @@ -153,10 +153,10 @@ public boolean mediate(MessageContext synCtx) {
exeMethod.invoke(commandObject);
} catch (NoSuchMethodException e) {
handleException("Cannot locate an execute() method on POJO class : " +
command.getClass(), e, synCtx);
command, e, synCtx);
} catch (Exception e) {
handleException("Error invoking the execute() method on POJO class : " +
command.getClass(), e, synCtx);
command, e, synCtx);
}
}

Expand Down