Correctly handle optionalNoCA verification #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic to approve optionalNoCA connections only checked if errnum was one of the known optional errors defined in the SSL_VERIFY_ERROR_IS_OPTIONAL macro. It did not account for the case where the error code was X509_V_OK. As a result, the condition was not met, and the function incorrectly proceeded as if the handshake had failed, causing the connection to be rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic to approve optionalNoCA connections only checked if errnum was one of the known optional errors defined in the SSL_VERIFY_ERROR_IS_OPTIONAL macro. It did not account for the case where the error code was X509_V_OK. As a result, the condition was not met, and the function incorrectly proceeded as if the handshake had failed, causing the connection to be rejected.