Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable fast SDK in CMake build #9853

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

JosiahWI
Copy link
Contributor

This adds a new option that defaults to OFF: ENABLE_FAST_SDK.

@JosiahWI JosiahWI self-assigned this Jun 15, 2023
@JosiahWI JosiahWI added Build work related to build configuration or environment CMake work related to CMakes scripts or issues labels Jun 15, 2023
@JosiahWI JosiahWI added this to the 10.0.0 milestone Jun 15, 2023
@JosiahWI JosiahWI requested a review from cmcfarlen June 15, 2023 13:41
CMakeLists.txt Outdated
@@ -38,6 +38,7 @@ execute_process(COMMAND uname -n OUTPUT_VARIABLE BUILD_MACHINE OUTPUT_STRIP_TRAI

# Options
set(DEFAULT_STACK_SIZE 1048576 CACHE STRING "Default stack size (default 1048576)")
option(ENABlE_FAST_SDK "Use fast SDK APIs (default OFF)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little L in this option

Copy link
Contributor

@cmcfarlen cmcfarlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix option symbol

@JosiahWI JosiahWI requested a review from cmcfarlen June 15, 2023 20:04
cmcfarlen
cmcfarlen previously approved these changes Jun 15, 2023
This adds a new option that defaults to OFF: ENABLE_FAST_SDK.
@JosiahWI
Copy link
Contributor Author

Rebased on master.

@bneradt bneradt merged commit 6935af7 into apache:master Jun 15, 2023
@JosiahWI JosiahWI deleted the feat/cmake-fast-sdk branch June 16, 2023 15:15
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (90 commits)
  doc: fix the internal libraries section formatting (apache#9879)
  Add max thread count options to CMake build (apache#9883)
  Add yaml libs reference to HTTP proxy test suite. Closes apache#9882 (apache#9885)
  Add transparent proxy support to CMake build (apache#9884)
  Check for symbol IP_TOS in CMake build (apache#9870)
  RAT license fix: renamed_records.out -> .gold (apache#9876)
  Add traffic_wccp to CMake build (apache#9867)
  cleanup cast warning with reinterpret_cast (apache#9866)
  Fixes Coverity 1513058, introduced with apache#9643 (apache#9860)
  add some missing libs for clang (apache#9865)
  Add support for libunwind in CMake build (apache#9862)
  Add option to build regression tests (apache#9863)
  Fix crash on config reload with BoringSSL (apache#9840)
  Check for SO_PEERCRED in CMake build (apache#9855)
  Check for SO_MARK in CMake build (apache#9854)
  Clean up UnixNetProcessor entanglements. (apache#9825)
  Remove unneeded DEBUG conditionals. (apache#9849)
  Add option to enable fast SDK in CMake build (apache#9853)
  Add support for POSIX Cap in CMake build (apache#9852)
  WCCP: remove ts::Buffer (apache#9824)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build work related to build configuration or environment CMake work related to CMakes scripts or issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants