Add support for libunwind in CMake build #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option that defaults to ON: ENABLE_UNWIND. On Linux, CMake will look for the library and link it globally if it is found. On other OSs, CMake will skip the check, because libunwind is only available on Linux.
JosiahWI
added
Build
cmcfarlen
requested changes
Jun 16, 2023
|
It's being linked globally. The header isn't included anywhere specifically in ATS. |
This consolidates the Linux-specific settings.
libunwind is also available on Mac, and since we don't fail if it's not found, there's no reason to look for it only on some operating systems.
cmcfarlen
approved these changes
Jun 16, 2023
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jun 16, 2023
* Add support for libunwind in CMake build This adds an option that defaults to ON: ENABLE_UNWIND. On Linux, CMake will look for the library and link it globally if it is found. On other OSs, CMake will skip the check, because libunwind is only available on Linux. * Move find_package(unwind) to Linux build section This consolidates the Linux-specific settings. * Do not REQUIRE libunwind * Move find_package(unwind) back with other packages libunwind is also available on Mac, and since we don't fail if it's not found, there's no reason to look for it only on some operating systems.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (90 commits) doc: fix the internal libraries section formatting (apache#9879) Add max thread count options to CMake build (apache#9883) Add yaml libs reference to HTTP proxy test suite. Closes apache#9882 (apache#9885) Add transparent proxy support to CMake build (apache#9884) Check for symbol IP_TOS in CMake build (apache#9870) RAT license fix: renamed_records.out -> .gold (apache#9876) Add traffic_wccp to CMake build (apache#9867) cleanup cast warning with reinterpret_cast (apache#9866) Fixes Coverity 1513058, introduced with apache#9643 (apache#9860) add some missing libs for clang (apache#9865) Add support for libunwind in CMake build (apache#9862) Add option to build regression tests (apache#9863) Fix crash on config reload with BoringSSL (apache#9840) Check for SO_PEERCRED in CMake build (apache#9855) Check for SO_MARK in CMake build (apache#9854) Clean up UnixNetProcessor entanglements. (apache#9825) Remove unneeded DEBUG conditionals. (apache#9849) Add option to enable fast SDK in CMake build (apache#9853) Add support for POSIX Cap in CMake build (apache#9852) WCCP: remove ts::Buffer (apache#9824) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option that defaults to ON: ENABLE_UNWIND. On Linux, CMake will look for the library and link it globally if it is found. On other OSs, CMake will skip the check, because libunwind is only available on Linux.