-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for SO_MARK in CMake build #9854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem unnecessary. Maybe we should just use #if SO_MARK
instead of making a new definition for this? afaict this is used in one place in the code.
I think it's a good idea to look into which options we don't need anymore, but the autotools build supports this option and it's documented as being available. Maybe we should do that separately? |
6eeb7b6
to
2075ddd
Compare
Rebased on master. |
2075ddd
to
1a07992
Compare
This adds a new CMake option that is ON by default: ENABLE_POSIX_CAP. If POSIX cap is not found, the configure step will fail and the user must disable the feature explicitly.
3c7946c
to
03821dd
Compare
03821dd
to
ca9b632
Compare
* asf/master: (90 commits) doc: fix the internal libraries section formatting (apache#9879) Add max thread count options to CMake build (apache#9883) Add yaml libs reference to HTTP proxy test suite. Closes apache#9882 (apache#9885) Add transparent proxy support to CMake build (apache#9884) Check for symbol IP_TOS in CMake build (apache#9870) RAT license fix: renamed_records.out -> .gold (apache#9876) Add traffic_wccp to CMake build (apache#9867) cleanup cast warning with reinterpret_cast (apache#9866) Fixes Coverity 1513058, introduced with apache#9643 (apache#9860) add some missing libs for clang (apache#9865) Add support for libunwind in CMake build (apache#9862) Add option to build regression tests (apache#9863) Fix crash on config reload with BoringSSL (apache#9840) Check for SO_PEERCRED in CMake build (apache#9855) Check for SO_MARK in CMake build (apache#9854) Clean up UnixNetProcessor entanglements. (apache#9825) Remove unneeded DEBUG conditionals. (apache#9849) Add option to enable fast SDK in CMake build (apache#9853) Add support for POSIX Cap in CMake build (apache#9852) WCCP: remove ts::Buffer (apache#9824) ...
This sets the CMake variable TS_HAS_SO_MARK appropriately.