Skip to content

Conversation

@ColinLeeo
Copy link
Contributor

No description provided.

@ColinLeeo ColinLeeo requested review from Copilot and jt2594838 May 11, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation checks for table and column schema definitions and enhances numeric range checking in the Tablet class.

  • Added numeric range check support in add_value_by_index in Tablet.
  • Introduced validations for non-empty table/column names and non-null data types in TableSchema and ColumnSchema.
  • Updated and extended tests to cover the new schema validations and value insertion for string type columns.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
python/tsfile/tablet.py Added numeric range check in add_value_by_index similar to add_value_by_name.
python/tsfile/schema.py Added validations for column/table names and data types; note a redundant condition in TableSchema.
python/tests/test_basic.py Updated test cases to include a string column and to adjust for new validations in the schema.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.48%. Comparing base (217cc3c) to head (8bd62e0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #488   +/-   ##
========================================
  Coverage    65.48%   65.48%           
========================================
  Files          565      565           
  Lines        33040    33040           
  Branches      4603     4603           
========================================
  Hits         21636    21636           
  Misses       10762    10762           
  Partials       642      642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jt2594838 jt2594838 merged commit d2119c1 into develop May 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants