Skip to content

Conversation

@ColinLeeo
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.71%. Comparing base (6f08fb1) to head (55fc1ef).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #495      +/-   ##
===========================================
+ Coverage    65.69%   65.71%   +0.02%     
===========================================
  Files          565      565              
  Lines        33061    33062       +1     
  Branches      4610     4611       +1     
===========================================
+ Hits         21718    21728      +10     
+ Misses       10690    10684       -6     
+ Partials       653      650       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix data loss when the page number exceeds 1 by adding an additional test and updating page handling logic.

  • Introduce a new test case (WithoutTagAndMutiPage) to verify behavior with multiple pages.
  • Add a check in the aligned chunk reader to return an appropriate error when no more data is available.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
cpp/test/writer/table_view/tsfile_writer_table_test.cc Adds a new test verifying write/read functionality over multiple pages
cpp/src/reader/aligned_chunk_reader.cc Adds a safety check to ensure proper handling of data exhaustion

break;
} else if (RET_FAIL(skip_cur_page())) {
}
if (!has_more_data()) {
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] A comment explaining why returning E_NO_MORE_DATA in this condition is critical for loop termination could help maintain clarity.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ColinLeeo ColinLeeo merged commit 14cefc9 into develop May 15, 2025
13 checks passed
@ColinLeeo ColinLeeo deleted the colin_fix_data_lossing branch May 15, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants