[ZOOKEEPER-3657] Implementing snapshot schedule to avoid high latency issue due to disk contention #1191
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.zookeeper.server; | ||
|
|
||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Util class Used to control the behavior abouthow we take snapshot. | ||
| */ | ||
| public class SnapshotGenerator { | ||
| private static final Logger LOG = LoggerFactory.getLogger(SnapshotGenerator.class); | ||
|
|
||
| public static final String PURGE_AFTER_SNAPSHOT = "zookeeper.purgeAfterSnapshot.enabled"; | ||
| private static boolean purgeAfterSnapshot; | ||
|
|
||
| public static final String FSYNC_SNAPSHOT_FROM_SCHEDULER = "zookeeper.fsyncSnapshotFromScheduler"; | ||
| private static boolean fsyncSnapshotFromScheduler; | ||
|
|
||
| static { | ||
| purgeAfterSnapshot = Boolean.getBoolean(PURGE_AFTER_SNAPSHOT); | ||
| LOG.info("{} = {}", PURGE_AFTER_SNAPSHOT, purgeAfterSnapshot); | ||
|
|
||
| fsyncSnapshotFromScheduler = Boolean.parseBoolean( | ||
|
Contributor
There was a problem hiding this comment. why not use Boolean.getBoolean so it's consistent with previous property parsing code (also less verbose)? |
||
| System.getProperty(FSYNC_SNAPSHOT_FROM_SCHEDULER, "true")); | ||
| LOG.info("{} = {}", FSYNC_SNAPSHOT_FROM_SCHEDULER, fsyncSnapshotFromScheduler); | ||
| } | ||
|
|
||
| public static boolean getPurgeAfterSnapshot() { | ||
| return purgeAfterSnapshot; | ||
| } | ||
|
|
||
| public static void setPurgeAfterSnapshot(boolean enabled) { | ||
| purgeAfterSnapshot = enabled; | ||
| LOG.info("{} = {}", PURGE_AFTER_SNAPSHOT, purgeAfterSnapshot); | ||
| } | ||
|
|
||
| public static void setFsyncSnapshotFromScheduler(boolean fsync) { | ||
| fsyncSnapshotFromScheduler = fsync; | ||
| LOG.info("{} = {}", FSYNC_SNAPSHOT_FROM_SCHEDULER, fsyncSnapshotFromScheduler); | ||
| } | ||
|
|
||
| public static boolean getFsyncSnapshotFromScheduler() { | ||
| return fsyncSnapshotFromScheduler; | ||
| } | ||
|
|
||
| private final ZooKeeperServer zks; | ||
| private final ExecutorService worker; | ||
| private final AtomicBoolean isTakingSnapshot; | ||
|
|
||
| public SnapshotGenerator(final ZooKeeperServer zks) { | ||
| this.zks = zks; | ||
| this.worker = Executors.newFixedThreadPool(1); | ||
| this.isTakingSnapshot = new AtomicBoolean(false); | ||
| } | ||
|
|
||
| public boolean takeSnapshot(boolean syncSnap) { | ||
| // Only allow a single snapshot in progress. | ||
| if (isTakingSnapshot.compareAndSet(false, true)) { | ||
| this.worker.execute(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| try { | ||
| zks.takeSnapshot(syncSnap); | ||
| if (purgeAfterSnapshot) { | ||
| zks.purge(); | ||
| } | ||
| } catch (Exception e) { | ||
| LOG.warn("Unexpected exception", e); | ||
| } finally { | ||
| isTakingSnapshot.compareAndSet(true, false); | ||
| } | ||
| } | ||
| }); | ||
| return true; | ||
| } else { | ||
| LOG.warn("Previous snapshot is still in-flight, too busy to snap, skipping"); | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| public boolean isSnapInProgress() { | ||
| return isTakingSnapshot.get(); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these really java system properties only? Put a config foo in zoo.cfg and ZK will parse them and generate a zookeeoer.foo. similar for other "java only system properties" listed here. might need update doc.