Merge pull request #400 from apex-dev-tools/fix/issue-398-ghosted-type-list-unused

fix: Track variable usage in ghosted type list initializers (fixes #398)

Author: kjonescertinia

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Loop variables used only in iteration control (condition/increment) are no longer incorrectly flagged as unused (#397)
+- Variables used in ghosted type list initializers are no longer incorrectly flagged as unused (#398)
 
 ## [6.0.1] - 2025-10-21
 

jvm/src/main/scala/com/nawforce/apexlink/cst/Creator.scala

@@ -433,6 +433,8 @@ final case class SetOrListCreatorRest(parts: ArraySeq[Expression]) extends Creat
       case Left(error) =>
         if (!context.module.isGhostedType(enclosedType.get))
           context.log(error.asIssue(location))
+        // Still verify parts for variable usage tracking, even though we can't type check
+        parts.foreach(_.verify(input, context))
         ExprContext.empty
       case Right(toType) =>
         // For each expression check we can assign to the generic type

jvm/src/test/scala/com/nawforce/apexlink/plugin/UnusedTest.scala

@@ -1411,6 +1411,59 @@ class UnusedTest extends AnyFunSuite with TestHelper {
     }
   }
 
+  // Tests for issue #398 - Variables in ghosted type list initialization
+
+  test("Variable used in ghosted type list initializer should not be flagged (issue #398)") {
+    FileSystemHelper.run(
+      Map(
+        "sfdx-project.json" ->
+          """{
+            |"packageDirectories": [{"path": "force-app"}],
+            |"plugins": {"dependencies": [{"namespace": "ext"}]}
+            |}""".stripMargin,
+        "force-app/Dummy.cls" -> "public class Dummy { { String msg = 'test'; List<ext__Type__c> items = new List<ext__Type__c>{ new ext__Type__c(Name = msg) }; System.debug(items); } }"
+      )
+    ) { root: PathLike =>
+      createOrgWithUnused(root)
+      assert(getMessages(root.join("force-app/Dummy.cls")).isEmpty)
+    }
+  }
+
+  test("Variable used in multiple ghosted type list elements should not be flagged") {
+    FileSystemHelper.run(
+      Map(
+        "sfdx-project.json" ->
+          """{
+            |"packageDirectories": [{"path": "force-app"}],
+            |"plugins": {"dependencies": [{"namespace": "ext"}]}
+            |}""".stripMargin,
+        "force-app/Dummy.cls" -> "public class Dummy { { String msg1 = 'test1'; String msg2 = 'test2'; List<ext__Type__c> items = new List<ext__Type__c>{ new ext__Type__c(Name = msg1), new ext__Type__c(Name = msg2) }; System.debug(items); } }"
+      )
+    ) { root: PathLike =>
+      createOrgWithUnused(root)
+      assert(getMessages(root.join("force-app/Dummy.cls")).isEmpty)
+    }
+  }
+
+  test("Unused variable with ghosted type list should still be flagged") {
+    FileSystemHelper.run(
+      Map(
+        "sfdx-project.json" ->
+          """{
+            |"packageDirectories": [{"path": "force-app"}],
+            |"plugins": {"dependencies": [{"namespace": "ext"}]}
+            |}""".stripMargin,
+        "force-app/Dummy.cls" -> "public class Dummy { { String msg1 = 'test'; String unused = 'unused'; List<ext__Type__c> items = new List<ext__Type__c>{ new ext__Type__c(Name = msg1) }; System.debug(items); } }"
+      )
+    ) { root: PathLike =>
+      createOrgWithUnused(root)
+      assert(
+        getMessages(root.join("force-app/Dummy.cls")) ==
+          "Unused: line 1 at 52-69: Unused local variable 'unused'\n"
+      )
+    }
+  }
+
   // Additional tests for issue #397 - for loop variable usage detection
 
   test("For loop with multiple variables - unused second variable should be flagged") {