Skip to content

fix: check join_thread attribute in queue when cleaning mp exec #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: check join_thread attribute in queue when cleaning mp exec #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

# Unreleased

### Fixed

- Fix `join_thread` missing attribute in `SimpleQueue` when cleaning a multiprocessing executor

## v0.14.0 (2024-11-14)

### Added
Expand Down
6 changes: 4 additions & 2 deletions edsnlp/processing/multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,8 @@ def run(self):
for stage in self.stages_to_run:
for name, queue in self.consumer_queues(stage):
queue.close()
queue.join_thread()
if hasattr(queue, "join_thread"):
queue.join_thread()

self.final_barrier.wait()

Expand Down Expand Up @@ -1182,7 +1183,8 @@ def feed_queue(self, queue, items):
if q is queue:
queue.put(STOP)
queue.close()
queue.join_thread()
if hasattr(queue, "join_thread"):
queue.join_thread()

def dequeue_notifications(self):
while True:
Expand Down
Loading