Allow to fetchEager a non-serializable property fix #1290 #1297
Conversation
|
@soyuka thanks for the quick work! |
|
Hmm yes indeed updated ^^. |
|
Perfect, works for me! |
|
Obviously the docs should be updated, but also clarified, as at the moment the eager loading page (https://api-platform.com/docs/core/performance) doesn't really say that eager loading is linked to serialization. |
|
|
||
| if (false === $propertyMetadata->isReadableLink() || false === $propertyMetadata->isReadable()) { | ||
| continue; | ||
| if (false === $propertyMetadata->getAttribute('fetchEager', false)) { |
There was a problem hiding this comment.
You can merge this condition with the previous one!
There was a problem hiding this comment.
not really :|. I tried things in my head but it doesn't seem to end up well because it's not a condition to break but rather a condition to not break when we should have.
There was a problem hiding this comment.
plus this is far more readable.
There was a problem hiding this comment.
okay got it I think:
if ((false === $propertyMetadata->isReadableLink() || false === $propertyMetadata->isReadable()) && false === $propertyMetadata->getAttribute('fetchEager', false)) {
continue;
}
|
good to merge @soyuka ? |
|
Needs rebase but good to merge. |
The following will bypass `readable` and `readableLink`: ``` @ApiProperty(attributes={"fetchEager": true}) ```
Allow to fetchEager a non-serializable property fix api-platform#1290
5 participants
The following will bypass
readableandreadableLink:ping @bendavies could you give this a try?