Skip to content

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Sep 11, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

NelmioApiDocBundle 3 has native support for API Platform. Deprecating our support for v2.

Copy link
Member

@meyerbaptiste meyerbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a @group legacy annotation for ApiPlatformParserTest and ApiPlatformProviderTest classes.

@soyuka
Copy link
Member

soyuka commented Sep 12, 2017

fix #1299 ?

Adding those annotations didn't work, I think we should use trigger_error in the constructor instead of in the file.

/**
* @author Teoh Han Hui <teohhanhui@gmail.com>
*
* @group legacy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a @expectedDeprecation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Deprecate in the constructor
@dunglas dunglas merged commit 084be5b into api-platform:master Sep 12, 2017
@dunglas dunglas deleted the nelmio branch September 12, 2017 10:05
@dunglas
Copy link
Member Author

dunglas commented Sep 12, 2017

Thanks @soyuka

hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants