hotfix: add exception when the action is not a builtin action

[Simperfit]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	none
License	MIT
Doc PR	none

We should not use POST in itemOperation (it is not supported) and each unsupported actionName should not be able to be used since it break NelmioApiDoc.

Thanks to @dunglas for the help.

[dunglas]

👍

[teohhanhui]

We should use a more specific wildcard here...

[dunglas]

Argument::type('string') indeed

[teohhanhui]

We can limit it to the specific values we need here.
On 27 Jun 2016 21:50, "Kévin Dunglas" notifications@github.com wrote:

In tests/Bridge/Symfony/Routing/ApiLoaderTest.php
#586 (comment):

@@ -113,6 +115,10 @@ private function getApiLoaderWithResourceMetadata(ResourceMetadata $resourceMeta

     $kernelProphecy = $this->prophesize(KernelInterface::class);
     $kernelProphecy->locateResource(Argument::any())->willReturn($routingConfig);

•    $containerBuilderProphecy = $this->prophesize(ContainerBuilder::class);
  

•    $kernelProphecy->getContainer()->willReturn($containerBuilderProphecy);
  

•    $containerBuilderProphecy->has(Argument::any())->willReturn(true);
  

Argument::type('string') indeed

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/api-platform/core/pull/586/files/6b32716eb4e97b5aadd594a29fb7ee625b0490a8#r68579198,
or mute the thread
https://github.com/notifications/unsubscribe/AAhf647GnFhS_HyQaZz6cQNKgae5Pvahks5qP9VDgaJpZM4I-_Cx
.

[theofidry]

As @teohhanhui said, we expect specific values here don't we? So we should check against them :)

[Simperfit]

I will use both since I want to test that the exception is triggered correctly

[Simperfit]

Thanks @teohhanhui @theofidry @dunglas for reviewing this PR :)

[teohhanhui]

$containerProphecy = $this->prophesize(ContainerInterface::class);
// ...
$kernelProphecy->getContainer()->willReturn($containerProphecy->reveal());

[theofidry]

or:

$containerProphecy = $this->prophesize(ContainerInterface::class);
/** @var ContainerInterface $container */
$container = $containerProphecy->reveal();
// ...
$kernelProphecy->getContainer()->willReturn($container);

if you want to benefit from the typehint and avoid raising a warning on Scrutinizer.

[teohhanhui]

@theofidry I know @dunglas does not like extra variables... 😛

[theofidry]

I'm not pleased with it either but there is no workaround, to avoid that and benefit from the typehint there is phpSpec for that. But I don't like forcing the users to use phpSpec and you loose your code coverage as well...

Anyway let's blame @dunglas tastes in the meantime 😆

[dunglas]

I prefer PHPSpec too, and I use it for my private projects. But I'm tired of "I don't know PHPSpec so I let you write tests." or "I dont't know PHPSpec so I wrote PHPUnit tests." comments ;)

[theofidry]

"I don't know PHPSpec so I let you write tests." or "I don't know PHPSpec so I wrote PHPUnit tests."

The problem isn't here, it's "I won't contribute because I'm not willing to learn a new testing tool just for this project". It's arguable, but that's the reason why we stayed to phpunit.

[teohhanhui]

Can we agree then that there shall be no inline ->reveal()?

[Simperfit]

I'm going for it ;)

[Simperfit]

comments addressed

[theofidry]

👍

[dunglas]

Thank you @Simperfit