[swagger-v2] feat: add tests and add collection #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
force-pushed
the
feature/swagger-v2
branch
2 times, most recently
from
72ba1dd to
69785c6
Compare
Simperfit
changed the title
Simperfit
force-pushed
the
feature/swagger-v2
branch
from
cd40781 to
db42275
Compare
|
This PR has been rebased with master |
| private $host; | ||
| private $schema; | ||
| private $formats; | ||
| const SWAGGER_VERSION = '2.0'; |
There was a problem hiding this comment.
According to our CS constants must be before properties (and add a blank line between constants an property).
|
Comments Addressed |
Simperfit
force-pushed
the
feature/swagger-v2
branch
from
37c5292 to
d1666cd
Compare
Simperfit
force-pushed
the
feature/swagger-v2
branch
from
d1666cd to
4169980
Compare
| ->children() | ||
| ->scalarNode('title')->defaultValue('')->info('The title of the API.')->end() | ||
| ->scalarNode('description')->defaultValue('')->info('The description of the API.')->end() | ||
| ->scalarNode('version')->defaultValue('')->info('The version of the API.')->end() |
|
Thank you @Simperfit |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.