Skip to content

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jul 14, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #614
License MIT
Doc PR

@Simperfit Simperfit force-pushed the feature/fix-614-custom-path branch 3 times, most recently from 7d88ea3 to a0e4adc Compare July 14, 2016 10:43
$classes = [];
$operation = [];
$customOperation = [];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those 2 blank lines must be removed.

@dunglas
Copy link
Member

dunglas commented Jul 14, 2016

Can you add a non-regression test please?

@Simperfit Simperfit force-pushed the feature/fix-614-custom-path branch 2 times, most recently from 05b09ab to 58db35e Compare July 14, 2016 12:49
@Simperfit Simperfit force-pushed the feature/fix-614-custom-path branch from 58db35e to f5bf547 Compare July 14, 2016 12:50
@Simperfit
Copy link
Contributor Author

added a test

@dunglas dunglas merged commit 52f4677 into api-platform:master Jul 14, 2016
@dunglas
Copy link
Member

dunglas commented Jul 14, 2016

Thank you @Simperfit

@samvdb
Copy link
Contributor

samvdb commented Jul 14, 2016

Thank you very much @Simperfit ! Awesome work

@Simperfit
Copy link
Contributor Author

Thanks both of you @dunglas @samvdb, that's nice ! ;)

@Simperfit Simperfit deleted the feature/fix-614-custom-path branch August 13, 2016 06:44
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
…stom-path

feat: add custom operation in swagger fix api-platform#614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants