-
-
Notifications
You must be signed in to change notification settings - Fork 940
fix(symfony): object mapper compatibility #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What about adding the infected symfony/http-foundation to the conflicts as well in another PR? Or disabling / soft failing on it given this is a library. |
|
#7532 for that :) |
|
Weird. This PR according to Github's PR page wasn't included in the 4.2.4 tag, where #7532 for instance does. When looking at the commits this PR is listed though: https://github.com/api-platform/core/commits/v4.2.4/ Our Renovate CI runs start throwing exceptions on the latest tag, so the fix possibly isn't sufficient? Or does Renovate by default not combine all APIP package updates together that are needed for this fix to come through? |
| final class ObjectMapper implements ObjectMapperInterface | ||
| { | ||
| public function __construct(private ObjectMapperInterface $decorated) | ||
| if (class_exists(ObjectMapperAwareInterface::class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the if should be the other way around. The way it is right now you're including ObjectMapperAwareInterface if it doesn't exist and not if it does, which obviously doesn't make sense.
fixes #7504