Skip to content

Fix SwaggerCommandTest #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Fix SwaggerCommandTest #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions ...fony/Bundle/Command/SwaggerComandTest.php → ...ony/Bundle/Command/SwaggerCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,26 @@

namespace ApiPlatform\Core\Tests\Bridge\Symfony\Bundle\Command;

use Nelmio\ApiDocBundle\Tests\WebTestCase;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Console\Tester\ApplicationTester;

/**
* @author Amrouche Hamza <hamza.simperfit@gmail.com>
*/
class SwaggerComandTest extends WebTestCase
class SwaggerCommandTest extends KernelTestCase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! I didn't see that in the first place

{
public function testExecute()
{
$this->getContainer();
self::bootKernel();

$application = new Application(static::$kernel);
$application->setCatchExceptions(false);
$application->setAutoExit(false);

$tester = new ApplicationTester($application);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tester/CommandTester.php is the right helper to use here.

For example, see https://github.com/symfony/symfony/blob/5129c4cf7e294b1a5ea30d6fec6e89b75396dcd2/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDebugCommandTest.php

$input = [
'command' => 'api:swagger:export',
];
$tester->run($input);
$display = $tester->getDisplay();
$this->assertJson($display);
$tester->run(['command' => 'api:swagger:export']);

$this->assertJson($tester->getDisplay());
}
}