Skip to content

Etherscan v2 compliance update #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

Etherscan v2 compliance update #636

merged 2 commits into from
Oct 16, 2025

Conversation

hiletmis
Copy link
Contributor

Closes #635

This PR updates verification API to etherscan for following chains:

  • katana-sepolia-testnet
  • taiko-hoodi-testnet

@hiletmis hiletmis requested a review from bdrhn9 October 10, 2025 12:36
@hiletmis hiletmis marked this pull request as ready for review October 10, 2025 12:37
@hiletmis hiletmis requested a review from bbenligiray as a code owner October 10, 2025 12:37
bdrhn9
bdrhn9 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I re-ran CI to check for any new support from Etherscan V2. There wasn't any. However, it failed because of the gnosis default provider, which hasn't been reliable for a few hours.

@bdrhn9
Copy link
Contributor

bdrhn9 commented Oct 14, 2025

Just out of my curiosity, did you re-run verify script? As I checked contracts are also verified on new block explorers.

@hiletmis
Copy link
Contributor Author

Just out of my curiosity, did you re-run verify script? As I checked contracts are also verified on new block explorers.

Yes I have verified them on new explorer settings, at the time they were not verified

@hiletmis hiletmis merged commit 34771b1 into main Oct 16, 2025
5 of 7 checks passed
@hiletmis hiletmis deleted the etherscan-v2-compliance-1 branch October 16, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdrhn9 bdrhn9 bdrhn9 approved these changes

@bbenligiray bbenligiray Awaiting requested review from bbenligiray bbenligiray is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Etherscan V2 API compliance

2 participants

@hiletmis @bdrhn9