Configure package.json for npm package publishing #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
Oct 1, 2025
| "dist" | ||
| ], | ||
| "exports": { | ||
| ".": "./dist/src/index.js" |
There was a problem hiding this comment.
Mhh, won't this cause the JS imports not to work for any non index.js file? 🤔 I forgot how exactly the exports works.
There was a problem hiding this comment.
That is correct but my intention was to have a single entrypoint to act as the primary public API for the package. So if we need to expose more functions from other files then we make the index.ts file re-export it without the need to come an update the package.json file
acenolaza
force-pushed
the
38-npm-package-support
branch
from
4371c08 to
e93eaac
Compare
|
Actually the issue shouldn't be closed. It should be only closed after the package is successfully released on NPM. For that we need to integrate https://github.com/api3dao/commons/tree/main/src/release-scripts#tagandrelease and I'll need to adjust the GH secrets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #38
Tested locally by running
pnpm packto create a TAR compressed file and importing it in another repo.