Skip to content

fix(release): unify the node.js version used for binary #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2025
Merged

fix(release): unify the node.js version used for binary #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02a9a17
ci(release): fix pre-built binary v8 crash
bzp2010 Oct 20, 2025
389f5a6
tsnode
bzp2010 Oct 20, 2025
c4cab4d
node 22.20.0
bzp2010 Oct 20, 2025
147eeff
pnpx
bzp2010 Oct 20, 2025
e989e5c
chore
bzp2010 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Release
on:
push:
tags:
- 'v*.*.*'
- "v*.*.*"
jobs:
adc:
runs-on: ubuntu-latest
Expand All @@ -14,20 +14,21 @@ jobs:
# Build and test ADC CLI
- uses: actions/setup-node@v4
with:
node-version: 'lts/*'
node-version: "lts/*"
- uses: pnpm/action-setup@v4
- name: Build ADC
env:
NODE_VERSION: 22.17.0
run: |
node -v
pnpm install
NODE_ENV=production npx nx build cli
node --experimental-sea-config apps/cli/node-sea.json
npx ts-node apps/cli/scripts/download-node.ts
npx postject ./node-binary/linux-amd64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
npx postject ./node-binary/linux-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
npx postject ./node-binary/win-x64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
npx postject ./node-binary/win-arm64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
pnpx ts-node apps/cli/scripts/download-node.ts
pnpx postject ./node-binary/linux-amd64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
pnpx postject ./node-binary/linux-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
pnpx postject ./node-binary/win-x64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
pnpx postject ./node-binary/win-arm64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2

- name: Compress ADC
run: |
Expand Down Expand Up @@ -61,20 +62,20 @@ jobs:
# Build and test ADC CLI
- uses: actions/setup-node@v4
with:
node-version: 'lts/*'
node-version: "lts/*"
- uses: pnpm/action-setup@v2
with:
version: latest
- name: Build ADC
env:
NODE_VERSION: 22.20.0
run: |
pnpm install
NODE_ENV=production npx nx build cli
node --experimental-sea-config apps/cli/node-sea.json
npx ts-node apps/cli/scripts/download-node.ts
pnpx ts-node apps/cli/scripts/download-node.ts
codesign --remove-signature ./node-binary/darwin-arm64
codesign --remove-signature ./node-binary/darwin-x64
npx postject ./node-binary/darwin-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
npx postject ./node-binary/darwin-x64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
pnpx postject ./node-binary/darwin-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
pnpx postject ./node-binary/darwin-x64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
codesign --sign - ./node-binary/darwin-arm64
codesign --sign - ./node-binary/darwin-x64

Expand Down
7 changes: 6 additions & 1 deletion apps/cli/scripts/download-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import { execSync } from 'child_process';
import { cpSync, existsSync, mkdirSync, rmSync, unlinkSync } from 'fs';
import { Listr } from 'listr2';

const version = process.env.NODE_VERSION ?? '20.15.1';
const version = process.env.NODE_VERSION;

if (!version) {
console.error('empty NODE_VERSION environment variable');
process.exit(1);
}

const tasks = new Listr([
{
Expand Down
Loading