-
Notifications
You must be signed in to change notification settings - Fork 18
docs: added README #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 62.73% 62.55% -0.18%
==========================================
Files 16 16
Lines 1127 1127
==========================================
- Hits 707 705 -2
- Misses 356 357 +1
- Partials 64 65 +1
Continue to review full report at Codecov.
|
pottekkat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure that the headings and the sentences follow the sentence case? See: https://apisix.apache.org/docs/general/documentation-style-guide
README.md
Outdated
|
|
||
| The following figure is the topology diagram of APISIX-Seed deployment. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to use relative paths? The image is not being shown on the preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand what you mean, this is a relative path. You want me to change to:

?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
cc @navendu-pottekkat review again pls, thank you |
|
It seems to work on the fork. |

Fixes: #5