support unicode length validation #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@Gerrard-YNWA please sign the CLA, thx |
membphis
reviewed
Mar 24, 2020
membphis
reviewed
Mar 24, 2020
membphis
reviewed
Mar 24, 2020
membphis
reviewed
Mar 24, 2020
Contributor
Author
|
@membphis thanks for reviewing my pr! I have pushed some updates according to your suggestions. Would you please review it again ? |
membphis
approved these changes
Mar 24, 2020
Contributor
|
@Gerrard-YNWA nice job! merged already |
Contributor
|
I will release a new version next week. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8 string length checks not behave as expected.