Skip to content

fix: allow injecting false default value #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

fix: allow injecting false default value #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/jsonschema.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ generate_validator = function(ctx, schema)
end
ctx:stmt( ' end') -- if prop

if type(subschema) == "table" and subschema.default and
if type(subschema) == "table" and subschema.default ~= nil and
(type(subschema.default) == "number" or
type(subschema.default) == "string" or
type(subschema.default) == "boolean" or
Expand Down Expand Up @@ -964,7 +964,7 @@ generate_validator = function(ctx, schema)
end
end
ctx:stmt(') then')
ctx:stmt(' return false, "matches non of the enum values"')
ctx:stmt(' return false, "matches none of the enum values"')
ctx:stmt('end')
end

Expand Down
17 changes: 17 additions & 0 deletions t/default.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,3 +133,20 @@ local rule = {

local validator = jsonschema.generate_validator(rule)
assert(rule.id == "root:/", "fail: schema id is removed")

----------------------------------------------------- test case 6
local rule = {
type = "object",
properties = {
foo = {type = "boolean", default = false}
}
}

local validator = jsonschema.generate_validator(rule)
local t = {}
local ok, err = validator(t)
if not ok then
ngx.say("fail: inject default false value: ", err)
return
end
assert(t.foo == false, "fail: inject default false value")