feat: Clarify numerical validation errors #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current messages for `minimum` and `maximum` were misleading for a wide audience. Messages are now changed to "at least" for `minimum` and "at most" for `maximum`. Code simplified.
membphis
approved these changes
Feb 25, 2021
lib/jsonschema.lua
Outdated
| ctx:stmt(sformat(' if %s %s %s then', ctx:param(1), op, schema.minimum)) | ||
| ctx:stmt(sformat(' return false, %s("expected %%s to be %s than %s", %s)', | ||
| ctx:libfunc('string.format'), msg, schema.minimum, ctx:param(1))) | ||
| local addRangeCheck = function (op, reference, msg) |
Contributor
There was a problem hiding this comment.
This way of writing has a bad performance. You can use this way:
local function(ctx, op, reference, msg)
... ...
end
generate_validator = function(ctx, schema)
...
if schema.minimum then
addRangeCheck(ctx, '<', schema.minimum, 'at least')
end
...
end
Contributor
Author
There was a problem hiding this comment.
Sorry for delay. I incorporated your improvement.
membphis
requested changes
Feb 25, 2021
Contributor
membphis
left a comment
membphis
left a comment
There was a problem hiding this comment.
please change to new way
Contributor
|
ping @ypnos |
|
|
ypnos
changed the title
ypnos
changed the title
membphis
approved these changes
Apr 19, 2021
Contributor
|
@spacewander do you have time to look at this PR? many thx |
spacewander
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current messages for
minimumandmaximumwere misleading for a wide audience. Messages are now changed to "at least" forminimumand "at most" formaximum.Code simplified.