feat: more human friendly makefile output prompts #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leslie tsang <leslie.tsang@icloud.com>
|
|
Contributor
|
Let's merge master to make CI pass. |
Contributor
Author
Done |
membphis
approved these changes
Jan 14, 2022
spacewander
approved these changes
Jan 14, 2022
| ifneq ($(shell command -v gawk),) | ||
| ENV_HELP_AWK_RULE ?= '{ if(match($$0, /^\s*\#{3}\s*([^:]+)\s*:\s*(.*)$$/, res)){ printf(" make %-15s : %-10s\n", res[1], res[2]) } }' | ||
| else | ||
| ENV_HELP_AWK_RULE := '{ if(match($$0, /^\#\#\#([^:]+):(.*)$$/)){ split($$0, res, ":"); gsub(/^\#\#\#[ ]*/, "", res[1]); _desc=$$0; gsub(/^\#\#\#([^:]+):[ \t]*/, "", _desc); printf(" make %-15s : %-10s\n", res[1], _desc) } }' |
Contributor
There was a problem hiding this comment.
If I am you, I will prompt that people should use gawk instead. mawk is faster. But it doesn't support UTF8 well and one day you will find the support of mawk should be dropped.
Contributor
Author
There was a problem hiding this comment.
Make sense, thanks for suggestion.
I add it for run test in container, I had change my mind. no necessary to increase maintenance costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile rules: help: Show Makefile rules. dev: Create a development ENV test: Run the test case clean: Clean the test case[ info ] Makefile rules: make help : Show Makefile rules make dev : Create a development ENV make test : Run the test case make clean : Clean the test caseSigned-off-by: leslie tsang leslie.tsang@icloud.com