feat: Add support of LuaJIT 64bit integer types #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kasen
changed the title
membphis
reviewed
Dec 2, 2021
| elseif jsontype == 'integer' then | ||
| return sformat(' (%s == "number" and %s(%s, 1.0) == 0.0) ', | ||
| datatype, ctx:libfunc('math.fmod'), ctx:param(1)) | ||
| return sformat(' ((%s == "number" or (%s == "cdata" and tonumber(%s) ~= nil)) and %s %% 1.0 == 0.0) ', |
Contributor
There was a problem hiding this comment.
we need a test case to check it.
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
I added a couple of tests
membphis
approved these changes
Dec 4, 2021
Contributor
|
many thx @Kasen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaJIT has a couple of 64bit integers, such as int64 and uint64. These types are represented as cdata, not numbers. This PR introduces the ability to check these types as jsonschema integer.