-
Notifications
You must be signed in to change notification settings - Fork 11
Decaffinate tests #15
Conversation
honzajavorek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thanks 👍
LGTM. My only concern would be that I'm proponent of the reverse approach:
- Decaf the code, leave tests intact, be sure nothing got broken.
- Decaf the tests.
However, we have a good past experience with the decaffeination, it's not breaking things, so it probably doesn't matter.
Also, you're right about the airbnb-base license issues.
.travis.yml
Outdated
|
|
||
| script: | ||
| - npm run lint | ||
| - npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: npm test is sufficient
I didn't want to approve technically, but just by words for now. Need to check all licenses etc.
|
I split off linting into #21. That means no dependency changes in this PR🎉 I decaffeinated the actual parser in #22. Feel free to merge that one first, I'll then rebase this one. Since releasing the decaffeinated code will be semver major (because of the bump to Node.js 6), it'd be great if you could checkout #16 as well. |
Adds some missing assertions that eslint found.
|
@michalholasek Rebased! |
honzajavorek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR does the following changes
I'll back out the eslint change into its own PR after a first review as the license issue for
eslint-config-airbnb-basestill exists.