fix: split the @font-face rule to make it valid
#1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
B4nan
approved these changes
May 31, 2024
Member
Author
|
|
barjin
added a commit
that referenced
this pull request
May 31, 2024
The fix from #1037 worked way too well. This PR only applies the font to the relevant `font-family`.  (I actually kinda like the look of it, but it all probably shouldn't be the same `font-weight`. I suppose the web team can deal with the design question later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the MDN docs, the
@font-face { font-family }descriptor can only be a singlestring | custom ident.Compare to
font-familyCSS property, which can be a priority list.This discrepancy is causing the tagline in the subprojects to look like ass (fig. 1)