fix: Remove output schema to dataset schema rewrites #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
B4nan
added
adhoc
|
Preview for this PR was built for commit |
github-actions
bot
added
the
t-tooling
valekjo
approved these changes
Oct 30, 2025
|
|
||
| # Rename output schema to dataset schema | ||
| rewrite ^/platform/actors/development/actor-definition/output-schema$ /platform/actors/development/actor-definition/dataset-schema permanent; | ||
| rewrite ^academy/deploying-your-code/output-schema$ /academy/deploying-your-code/dataset-schema permanent; |
There was a problem hiding this comment.
Question: Was this even correct? It's missing the leading / (and so do many other academy links)
There was a problem hiding this comment.
most likely not, https://docs.apify.com/academy/deploying-your-code/output-schema is not redirecting anywhere
There was a problem hiding this comment.
i see only those two that feel wrong:
https://github.com/apify/apify-docs/blob/master/nginx.conf#L536-L538
https://docs.apify.com/academy/advanced-web-scraping/scraping-paginated-sites doesnt redirect
and for some weird reason, https://docs.apify.com/academy/php redirects to GH pages URL (which also ends up as 404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.