Skip to content

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Nov 18, 2025

Note

Fixes and streamlines Python snippets in the inputs/outputs guide, correcting dataset push usage and formatting.

  • Docs (inputs_outputs.md)
    • Python examples:
      • Correct dataset.push_items usage (push list; remove invalid key args) and adjust set_output({'solution': solution}).
      • Normalize imports and function definitions (is_on_apify, get_input, set_output, add_all_numbers), removing extra spaces and blank lines.
      • Minor cleanup for local I/O paths and JSON formatting in examples.

Written by Cursor Bugbot for commit 5327aac. Configure here.

@vdusek vdusek self-assigned this Nov 18, 2025
@vdusek vdusek requested a review from honzajavorek as a code owner November 18, 2025 09:18
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 18, 2025
@github-actions github-actions bot added this to the 128th sprint - Tooling team milestone Nov 18, 2025
@vdusek vdusek requested a review from Pijukatel November 18, 2025 09:19
@vdusek vdusek added bug Something isn't working. documentation Improvements or additions to documentation. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 18, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 5327aac and is ready at https://pr-2096.preview.docs.apify.com!

Copy link
Collaborator

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look okay to me. Is it worth indenting the JSON we're sending to the dataset? I don't know the internals enough to have an opinion.

Now about the elephant in the room. I know it probably wasn't the aim of this PR, but text on the whole page acts as if the Python Apify SDK didn't exist. Is it from times when it didn't exist? Because today it would be better to mention that in Python you'd use the SDK the same way as in Node.js, and have the example in a third language, e.g. PHP, Java, Go, you name it.

Even if your aim was just to fix errors in the code examples, I think it would be worth to fix sentences such as

If you are using Node.js for your repo's code, you can use the apify package. Otherwise, you can use the useful environment variables...

Alternatively, when writing in a language other than JavaScript, we can create our own...

etc., which completely ignore the existence of the Python SDK. What do you think?

@Pijukatel Pijukatel self-requested a review November 19, 2025 09:39
@vdusek vdusek merged commit 2084e61 into master Nov 19, 2025
13 of 14 checks passed
@vdusek vdusek deleted the fix-python-docs branch November 19, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants