Conversation
B4nan
reviewed
Sep 10, 2021
| this.isManInTheMiddle = false; | ||
|
|
||
| if (proxyUrls && proxyUrls.some((url) => url.includes('apify.com'))) { | ||
| this.log.warning('Some Apify proxy features may work incorrectly. Please consider setting up Apify properties instead of `proxyUrls`.'); |
Member
There was a problem hiding this comment.
by "Apify properties" you mean env vars? maybe we should suggest login via CLI?
Contributor
Author
There was a problem hiding this comment.
Anything. Can be env vars, cli, groups and password in ProxyConfiguration etc.
Member
There was a problem hiding this comment.
maybe we could add a link to the docs to make it more clear
https://sdk.apify.com/docs/guides/proxy-management#apify-proxy-configuration
or maybe better
Contributor
Author
There was a problem hiding this comment.
Suggested change
| this.log.warning('Some Apify proxy features may work incorrectly. Please consider setting up Apify properties instead of `proxyUrls`.'); | |
| this.log.warning('Some Apify proxy features may work incorrectly. See https://sdk.apify.com/docs/guides/proxy-management#apify-proxy-configuration'); |
B4nan
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1119