feat: support channel and user links in YouTube regex#1178
Merged
Conversation
Member
|
@vladfrangu Hah, cool, someone resurrected this issue :D I would probably leave as it is with a comment about this special case. And maybe no one will ever need it. |
metalwarrior665
approved these changes
Sep 15, 2021
B4nan
approved these changes
Sep 15, 2021
Member
Author
|
How should I phrase the comment? |
Member
Yup, sounds good. Maybe |
Member
Author
|
Updated the message 👍 |
B4nan
deleted the
feat/match-channel-and-user-links-in-youtube-regex
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #526
One issue I found is that there seem to be channels on YouTube that work at the root level (https://www.youtube.com/jacksepticeye, https://www.youtube.com/pewdiepie are some that I found, and it seems that YouTube has redirects in place for all named channels (? citation needed)) so I don't exactly know how we should handle these. Thoughts @metalwarrior665?