feat(SessionPool): allow passing forceCloud down to the KV store#1186
Merged
feat(SessionPool): allow passing forceCloud down to the KV store#1186
forceCloud down to the KV store#1186Conversation
pocesar
reviewed
Sep 21, 2021
Co-authored-by: Paulo Cesar <461084+pocesar@users.noreply.github.com>
pocesar
suggested changes
Sep 21, 2021
Contributor
pocesar
left a comment
pocesar
left a comment
There was a problem hiding this comment.
just a nitpick on docs, otherwise LGTM. it should be advised to use persistStateKeyValueStoreId when using forceCloud: true, since the KV will be an unnamed one and might be confusing for users
Member
Author
|
Would you want me to add that just in documentation, or in code too? |
Contributor
|
both a warning (maybe even display the key value store ID created in the warning) and a documentation is good, since people won't know where the sessions went |
pocesar
approved these changes
Sep 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #752
Might need to change the documentation string, right now it's a 1:1 copy from KV