feat: requestList accepts proxyConfiguration for requestsFromUrls#1317
Merged
B4nan merged 1 commit intoapify:masterfrom Mar 28, 2022
barjin:feat/requestListProxy
Merged
feat: requestList accepts proxyConfiguration for requestsFromUrls#1317B4nan merged 1 commit intoapify:masterfrom barjin:feat/requestListProxy
requestsFromUrls#1317B4nan merged 1 commit intoapify:masterfrom
barjin:feat/requestListProxy
Conversation
B4nan
requested changes
Mar 28, 2022
Member
B4nan
left a comment
There was a problem hiding this comment.
looking good, please add at least one test that verifies the proxy is being actually used (can be just a unit test)
| * If `null`, the list will not be persisted and will only be stored in memory. Process restart | ||
| * will then cause the list to be crawled again from the beginning. We suggest always using a name. | ||
| * @param {Array<RequestOptions|Request|string>} sources | ||
| * @param {RequestListOptions['sources']} sources |
Member
There was a problem hiding this comment.
lets see how this will work with the old docs (it should work fine with the sdk 3 ts api docs, but here - god knows)
pocesar
approved these changes
Mar 28, 2022
B4nan
reviewed
Mar 28, 2022
| 'http://another.proxy.url', | ||
| ]; | ||
|
|
||
| const mock = sinon.mock(utils.publicUtils); |
Member
There was a problem hiding this comment.
dont forget to migrate this to jest when backporting (no need to do it now, we can backport larger chunk later)
B4nan
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1073
Intended use: